Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Reddit text and media handling #31

Closed
wants to merge 1 commit into from

Conversation

edwinRNDR
Copy link

Adds the preview media to the Post media. Also uses a concatenation of title and selftext for Post text.

@sokomishalov
Copy link
Owner

Hi @edwinRNDR!
Thanks for your contribution :)

I'm planning to release 0.4.0 version within a week, and one of the features will be field thumbnail in the Video class. I don't think that preview media is equal to other media of the post so I can add this functionality in the next release to prevent the implicit mixing of these data structures.
Is it ok for you?
You can watch it in this work-in-progress pull request #24.

Title and selftext concatenation looks fine to me.

@sokomishalov
Copy link
Owner

@edwinRNDR hey!
Thanks again for the contribution, your feature is available in 0.4.0 now.
I'll close this PR.

@edwinRNDR
Copy link
Author

Ah, apologies for my late reply. But this sounds all good to me. Just one thing, the reason I added the preview images is because they seem to often contain images that are not in any other media links in the Reddit json. Thank you for considering my PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants