Adds --no-magic flag

[angerman]

Under certain conditions you might want to sidestep the directory
expansion and auto argument discovery. --no-magic provides this.
External tools invoking doctest, and wishing full control over the
passed argument, might want to use --no-magic.

This should fix the first part of #155.

[angerman]

Can we get this with a version bump to 0.12? I'd adjust the corresponding cabal PR, to verify that doctest is 0.12 or later.

[sol]

@angerman first things first, thanks for looking into cabal doctest!

Now the straight talk, this code has issues, it

1. has no tests

2. is not well factored

3. is not correct, e.g. try

   ghci> stripNoMagic ["--no-magic"]
   (False,["--no-magic"])
   

   or

   ghci> stripNoMagic ["--no-magic", "--no-magic", "--foo"]
   (True,["--no-magic","--foo"])
   

I consider (2) and (3) symptoms of (1).

Regarding (2), the existing code is already quite spaghetti, so this may be broken window theory at work. But given this situation it is even more important that we don't make it any worse.

What I now did is: Instead of reviewing your code, I refactored the code and added --no-magic and --info myself (see #159).

Except for the unit tests, my code is untested (that is I did not try it manually).

Can you chime in and

• adapt your Cabal PR to use my branch and check if this works for you
• give Add --no-magic and --info #159 a code review

I'm closing this.