Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-doctest: Add support for --with-compiler #439

Merged
merged 1 commit into from
Jul 18, 2024
Merged

cabal-doctest: Add support for --with-compiler #439

merged 1 commit into from
Jul 18, 2024

Conversation

sol
Copy link
Owner

@sol sol commented Jul 16, 2024

No description provided.

@sol sol force-pushed the cabal-doctest branch from 30bff0a to 2554a92 Compare July 16, 2024 06:30
@sol
Copy link
Owner Author

sol commented Jul 16, 2024

@wismill FYI

src/Cabal.hs Outdated
Comment on lines 56 to 59
: args ++ [
"--with-compiler", doctest
, "--with-hc-pkg", ghcPkg
]) >>= waitForProcess >>= exitWith
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment if you intend to let cabal handle duplicated flags based on their order.

@sol sol force-pushed the cabal-doctest branch 22 times, most recently from d43e8a4 to 49ffc07 Compare July 18, 2024 00:56
@sol sol marked this pull request as ready for review July 18, 2024 00:56
This was referenced Jul 18, 2024
@sol sol force-pushed the cabal-doctest branch from 49ffc07 to f9597a3 Compare July 18, 2024 01:34
@sol sol enabled auto-merge (rebase) July 18, 2024 01:34
@sol sol force-pushed the cabal-doctest branch from f9597a3 to f9ad796 Compare July 18, 2024 01:59
@sol sol merged commit 21b6aac into main Jul 18, 2024
51 checks passed
@sol sol deleted the cabal-doctest branch July 18, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants