Desugar local build tools to build-tool-depends (fixes #516)
#567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
force-pushed
the
dev
branch
3 times, most recently
from
ac00ad9 to
4d4c3cf
Compare
mpilgrem
approved these changes
Sep 19, 2023
| @@ -351,7 +351,6 @@ data RenderBuildTool = BuildTools String | BuildToolDepends String | |||
|
|
|||
| renderBuildTool :: (BuildTool, DependencyVersion) -> RenderBuildTool | |||
| renderBuildTool (buildTool, renderVersion -> version) = case buildTool of | |||
There was a problem hiding this comment.
I assume it is a stylistic choice, but I noted the continued use of case even though type BuildTool has only one constructor.
|
@mpilgrem thanks a lot for the review. This is not going to land for now. I updated the PR description. |
|
Closing in favor of #599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cabal v1-, and Hackage still usescabal v1-: There seems to be no way to use build tools in Hackage packages (need v2-build) haskell/hackage-server#821build-tool-dependsshould specify at leastcabal-version: 2.0, however, that's not strictly true, see:build-toolsandbuild-tool-depends