-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pascal case for Enums, calculator program + Modified Hello program #12
base: main
Are you sure you want to change the base?
Conversation
Updated the Calculator example program Enums to Pascal case due to an issue on Playgrounds. See: solana-playground/solana-playground#191
Have modified the "Hello" program, adding a missing instruction to create the user token account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Would you mind updating the generated examples too? If you have the repo running locally you should be able to just run ./tests/compile-tests.sh
. Then check in the updated files.
Ah sorry, if you run The idea of that script is that if we change the compiler code, we can re-compile a bunch of code and verify that the output either isn't changed, or is changed in the expected way. So it runs against the locally compiled version of |
Calculator example program Enums changed to Pascal case due to an issue on Playgrounds.
See: solana-playground/solana-playground#191