Updated account-data-matching, bump-seed-canonicalization #407

Epistetechnician · 2024-09-01T15:11:27Z

Summary of Changes: Bump Seed Canonicalization

Frontmatter

Added keywords and tags fields in the new version.
Removed objectives field in the new version.

Summary Section

Updated the summary to be more concise and focused on the key points.

Lesson Section

Expanded explanation of bump seeds and canonical bumps.
Added detailed examples of insecure and secure PDA derivation.
Included code examples for both insecure and secure implementations.
Added explanation of using Anchor's seeds and bump constraints.

Code Examples

Added code examples for:
- Insecure PDA derivation using create_program_address.
- Secure PDA derivation using find_program_address.
- Using Anchor's seeds and bump constraints.

Test Section

Added a detailed test example to show how the secure implementation prevents multiple claims.

Challenge Section

Added a challenge section encouraging users to audit their own or others' programs for proper PDA derivation.

Callout Section

Added a callout section prompting users to push their code to GitHub and provide feedback.

Updated lesson for account data matching

Up-to date compatibility and clean format

prettier --write "/Users/shaan.s.patel/Desktop/SF Bounty/account-data-matching-updated.md"

Checked formatting... All matched files use Prettier code style!

@mikemaccana

Resolving comments made by @mikemaccana

# Changes Made to arbitrary-cpi.md 1. **Line Length**: Adjusted lines exceeding 80 characters for improved readability and adherence to contributing guidelines. 2. **Consistency**: Ensured consistent capitalization in headers and throughout the document. 3. **Code Snippets**: Updated Rust code snippets for compatibility with Anchor 0.29.0: - Used `Result<()>` instead of `ProgramResult` for return types - Applied `to_account_info()` method instead of `clone()` for account info - Utilized `key()` method instead of `key` for public keys 4. **Explanations**: Enhanced clarity in explanations, particularly for arbitrary CPIs and program checks concepts. 5. **Lab Instructions**: Refined step-by-step instructions in the lab section for clarity and ease of following. 6. **Links**: Added and reviewed cross-references, ensuring inclusion of all necessary links (e.g., link to previous Anchor CPIs lesson). 7. **Formatting**: Verified proper Markdown formatting throughout, including correct use of code blocks with language specifications. 8. **Content Structure**: Confirmed overall lesson structure (Summary, Lesson, Lab, Challenge) adheres to contributing guidelines. 9. **Callouts**: Verified presence of final callout encouraging user feedback on the lesson.

ran yarn prettier --write "arbitrary.md"

Updated hyperlinks

Frontmatter: Removed the 'objectives' field Added 'keywords' and 'tags' fields Simplified the 'description' Content structure: Removed the "Lesson" heading, integrating its content directly under the main sections Kept the overall structure (Summary, main content, Lab, Challenge) intact Code blocks: Removed language specifiers from code blocks (e.g., rust)4. Styling and formatting: - Removed bold formatting from some terms and links - Slightly adjusted some headings for better flow5. Content updates: - Slightly reworded some explanations for clarity - Removed some repetitive information - Consolidated some information in the Summary section6. Lab and Challenge sections: - These sections remain largely unchanged, with only minor wording adjustments7. Callout: - Retained the Callout component at the end of the documentOverall, the changes aim to streamline the content and improve readability while maintaining the core structure and information of the original lesson. The most significant changes are in the frontmatter and the removal of language specifiers from code blocks. The main content, examples, and practical sections (Lab and Challenge) remain very similar to the original version.

mikemaccana

Some good stuff but also a few things that seem odd - please see the comments in this PR. Also note that that multiple people are competing for some (but not all) of these lessons. We'd still love to get all the changes in though!

content/courses/program-security/account-data-matching.md

content/courses/program-security/bump-seed-canonicalization.md

docs/programs/examples.md

mikemaccana · 2024-09-16T23:40:52Z

@Epistetechnician you have a bunch of references to unboxed repos still in this code:

https://github.com/Unboxed-Software/solana-account-data-matching is now https://github.com/solana-developers/solana-account-data-matching
https://github.com/Unboxed-Software/solana-arbitrary-cpi is now https://github.com/solana-developers/arbitrary-cpi

Also https://github.com/Unboxed-Software/solana-course/blob/main/content/anchor-cpi - make this a link to https://solana.com/developers/courses/onchain-development/anchor-cpi in whatever style the links section in CONTRIBUTING.md uses.

If you fix these, and handle the merge conflicts (arbitrary-cpi has now been updated), I'll mark you as the winner for account-data-matching and bump-seed-canonicalization lessons.

content/courses/program-security/account-data-matching.md

mikemaccana

Some minor fixes (see above) still to go then this can go in.

content/courses/program-security/arbitrary-cpi.md

mikemaccana · 2024-09-24T04:54:58Z

content/courses/program-security/arbitrary-cpi.md

@@ -218,7 +221,7 @@ mints, distribution, and transfers, and a separate metadata program is used to
 assign metadata to tokens. So the vulnerability we go through here could also be
 applied to real tokens.

-#### 1. Setup
+### 1. Setup

 We'll start with the `starter` branch of
 [this repository](https://github.com/Unboxed-Software/solana-arbitrary-cpi/tree/starter).


You haven't fixed the link! Please don't resolve things unless the concerns are addressed.

content/courses/program-security/arbitrary-cpi.md

mikemaccana · 2024-09-30T07:15:59Z

@Epistetechnician you have a bunch of references to unboxed repos still in this code:
If you fix these I'll mark you as the winner for account-data-matching and bump-seed-canonicalization lessons.

You didn't update the old unboxed repos as requested (as mentioned in the Superteam Bounty), just made links to a new repo that didn't exist. As the bounty has ended, and another user did these changes we will give the prize to the user.

Epistetechnician and others added 13 commits August 26, 2024 17:29

updates

b8a43b4

Updated lesson for account data matching

Final updates

7dea1fb

Up-to date compatibility and clean format

Prettier updates

131e9e3

prettier --write "/Users/shaan.s.patel/Desktop/SF Bounty/account-data-matching-updated.md"

Yarn Prettier

fc51d70

Checked formatting... All matched files use Prettier code style!

Resolved Comments

e2708d9

Resolving comments made by @mikemaccana

yarn prettier

2334527

ran yarn prettier --write "arbitrary.md"

Update arbitrary-cpi.md

40937b1

Update arbitrary-cpi.md

9860304

Update arbitrary-cpi.md

98580b7

Update arbitrary-cpi.md

2885187

Resolving comments

cccc265

Updated hyperlinks

Epistetechnician requested a review from nickfrosty as a code owner September 1, 2024 15:11

Pretiier

1a2cb56

mikemaccana changed the title ~~Updated-bump-seed-canonicalization-lesson~~ Updated account-data-matching, arbitrary-cpi, and bump-seed-canonicalization-lesson Sep 5, 2024

mikemaccana suggested changes Sep 5, 2024

View reviewed changes

mikemaccana added the superteam-lesson-updates label Sep 5, 2024

Epistetechnician added 2 commits September 9, 2024 17:20

Resolving Comments

7394085

Prettier Formatting

eb362b6

Epistetechnician requested a review from mikemaccana September 10, 2024 17:44

mikemaccana added the superteam-winner label Sep 16, 2024

mikemaccana approved these changes Sep 16, 2024

View reviewed changes

content/courses/program-security/account-data-matching.md Outdated Show resolved Hide resolved

mikemaccana and others added 2 commits September 17, 2024 07:58

Tweak comment

db226cb

Resolve conflicts

5037abf

Epistetechnician changed the title ~~Updated account-data-matching, arbitrary-cpi, and bump-seed-canonicalization-lesson~~ Updated account-data-matching, bump-seed-canonicalization Sep 17, 2024

mikemaccana suggested changes Sep 24, 2024

View reviewed changes

Epistetechnician added 2 commits September 24, 2024 15:51

updates

74ab5fa

fix

4b6550e

Epistetechnician added 4 commits September 25, 2024 16:56

resolve conflicts

61d56d7

resolve conflicts

000db3b

fix

7092702

prettier formatting

75f48a9

mikemaccana removed the superteam-winner label Sep 30, 2024

mikemaccana mentioned this pull request Oct 2, 2024

account-data-matching and bump-seed-canonicalization lesson updates #353

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated account-data-matching, bump-seed-canonicalization #407

Updated account-data-matching, bump-seed-canonicalization #407

Epistetechnician commented Sep 1, 2024

mikemaccana left a comment •

edited

Loading

mikemaccana commented Sep 16, 2024 •

edited

Loading

mikemaccana left a comment

mikemaccana Sep 24, 2024

mikemaccana commented Sep 30, 2024 •

edited

Loading

Updated account-data-matching, bump-seed-canonicalization #407

Are you sure you want to change the base?

Updated account-data-matching, bump-seed-canonicalization #407

Conversation

Epistetechnician commented Sep 1, 2024

Summary of Changes: Bump Seed Canonicalization

Frontmatter

Summary Section

Lesson Section

Code Examples

Test Section

Challenge Section

Callout Section

mikemaccana left a comment • edited Loading

Choose a reason for hiding this comment

mikemaccana commented Sep 16, 2024 • edited Loading

mikemaccana left a comment

Choose a reason for hiding this comment

mikemaccana Sep 24, 2024

Choose a reason for hiding this comment

mikemaccana commented Sep 30, 2024 • edited Loading

mikemaccana left a comment •

edited

Loading

mikemaccana commented Sep 16, 2024 •

edited

Loading

mikemaccana commented Sep 30, 2024 •

edited

Loading