fix and improve Signer-auth course #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace "init" with "init_if_needed" for vault field in the struct InitializeVault<'info>. delete unnecessary parameters "accounts()" in the test typescript. Update the project repo links.
mikemaccana
suggested changes
Oct 17, 2024
There was a problem hiding this comment.
I started reviewing this but there were a immediately a bunch of small issues that can be fixed by reading https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md - see the comments above.
| description: | ||
| "Ensure instructions are only executed by authorized accounts by implementing | ||
| signer checks." | ||
| "Ensure instructions are only ran by authorized accounts by implmementing |
| ```rust | ||
| if !ctx.accounts.authority.is_signer { | ||
| return Err(ProgramError::MissingRequiredSignature.into()); | ||
| return Err(ProgramError::MissingRequiredSignature.into()); |
There was a problem hiding this comment.
4 spaces per CONTRIBUTING
| /// CHECK: This account will not be checked by Anchor | ||
| pub authority: UncheckedAccount<'info>, | ||
| pub new_authority: AccountInfo<'info>, | ||
| pub authority: AccountInfo<'info>, |
There was a problem hiding this comment.
|
|
||
| ```rust | ||
| ```typescript |
mikemaccana
reviewed
Oct 17, 2024
| }) | ||
| describe("signer-authorization", () => { | ||
| ... | ||
| it("Insecure withdraw should be successful", async () => { |
There was a problem hiding this comment.
See CONTRUBUTING.md re: 'BDD'
|
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The way to get the seed "*ctx.bumps.get("vault").unwrap()" is outdated for the latest anchor version.
Unnecessary parameters in "accounts()" in the test typescript.
Summary of Changes
Update the latest way to get the seed.
replace "init" with "init_if_needed" for vault field in the struct InitializeVault<'info>.
delete unnecessary parameters "accounts()" in the test typescript.
Update the project repo links.