This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
fix and improve owner-checks course #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….InitSpace.html) to calculate space needed for accounts. Delete Unnecessary parameters found in the test typescript. Consistently use "rpc()" as sending transactions in the test typescript.
mikemaccana
suggested changes
Oct 17, 2024
| @@ -3,45 +3,44 @@ title: Owner Checks | |||
| objectives: | |||
| - Explain the security risks associated with not performing appropriate owner | |||
| checks | |||
| - Use Anchor's `Account<'info, T>` wrapper and an account type to automate | |||
| - Implement owner checks using long-form Rust | |||
There was a problem hiding this comment.
We use 'native Rust' to mean without Anchor.
| owner checks | ||
| - Use Anchor's `#[account(owner = <expr>)]` constraint to explicitly define an | ||
| - Use Anchor’s `#[account(owner = <expr>)]` constraint to explicitly define an |
There was a problem hiding this comment.
Just use ' rather than smart quotes. Do a find/replace.
| represents the **program** that owns the account. Owner checks ensure that this | ||
| `owner` field in the `AccountInfo` matches the expected program ID. | ||
| As a refresher, the `AccountInfo` struct contains the following fields. An owner | ||
| check refers to checking that the `owner` field in the `AccountInfo` matches an |
There was a problem hiding this comment.
Suggested change
| check refers to checking that the `owner` field in the `AccountInfo` matches an | |
| check refers to checking that the `owner` field matches an |
There was a problem hiding this comment.
Seems clear we're already talking about AccountInfo here.
| @@ -81,7 +95,7 @@ declare_id!("Cft4eTTrt4sJU4Ar35rUQHx6PSXfJju3dixmvApzhWws"); | |||
| #[program] | |||
| pub mod owner_check { | |||
| use super::*; | |||
| ... | |||
| ... | |||
There was a problem hiding this comment.
Check indentation, this may be a tab characters, use four spaces.
| ```typescript | ||
| describe("owner-check", () => { | ||
| ... | ||
| it("Insecure withdraw should be successful", async () => { |
There was a problem hiding this comment.
See 'BDD' in CONTRIBUTING.md, and do that for all tests.
|
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Magic number found on space calculation.
Unnecessary parameters are found in the test typescript.
Two Different ways to send transactions are found.
Summary of Changes
Use InitSpace to calculate space needed for accounts.
Delete Unnecessary parameters found in the test typescript.
Consistently use "rpc()" as sending transactions in the test typescript.
Also, I made a PR for solana-owner-checks starter branch and a PR for solana-owner-checks solution branch
which must be synced with this PR.