fix and improve program-configuration course #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add “--skip-deploy” to the test command. Delete an unnecessary setup in the section "Adding a local-testing feature". Remove the challenge section.
mikemaccana
suggested changes
Oct 17, 2024
There was a problem hiding this comment.
Hi @wuuer ! While you didn't win this lesson you're welcome to rebase this PR on top of the current main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The error message is not expected in the section "Run the existing test" section.
The "--skip-deploy" option for the test command anchor test is required as the deploy function is found in the typescript. anchor test will deploy the program with program_data's upgrade_authority_address set to system program (11111111111111111111111111111111), which results in an error while running the test case "Initialize Admin config should be successfully" . Deploying the program by the typescript function deploy will set the program_data's upgrade_authority_address to the wallet used.
The course has included the challenging content.
Summary of Changes
Update the correct error message in the section "Run the existing test".
Add “--skip-deploy” to the test command.
Delete an unnecessary setup in the section "Adding a
local-testingfeature".Remove the challenge section.
Also, I made a PR for solana-admin-instructions starter branch and a PR for solana-admin-instructions solution branch
which must be synced with this PR.