fix: pow operation in both rust and ts #572
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In rust and typescript/js,
^
is a bitwise operation ofXOR
, not exponentiation as intended. to correctly represents 10 tokens with 6 decimal places of percision, this fix has to be made, otherwise10 * 10 ^ 6
would result in98
in binary computation. not the expected10 * 1_000_000
, this might be misleading.Summary of Changes
To fix
10 * 10 ^6
:in typescript the change is
10 * 10 ** 6
,while in rust it becomes
10 * 10u64.pow(6)
.Fixes #