Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add 'instruction handler' and separate from 'instruction' #70

Merged

Conversation

mikemaccana
Copy link
Collaborator

@mikemaccana mikemaccana commented Feb 13, 2024

Current terminology uses the same term for the function and the thing being processed, which does not make logical sense and causes difficulty when explaining Solana development ("the instructions process the instructions").

Anchor 0.29 uses 'handler' to describe instruction handlers (see the function names when you start a project with --template=multiple) and this seems like a fine way of distinguishing between instructions and (what we now call) instruction handlers.

Copy link
Collaborator

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good distinction and I like it a lot.

1 small nit, making the displayed link labels be instruction handler vice instruction-handler

docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
@nickfrosty nickfrosty self-requested a review February 24, 2024 20:53
@nickfrosty nickfrosty merged commit 926ef7e into solana-foundation:main Feb 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants