Only show Trusted Verified Build information #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am authority or trusted signers
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Woody4618
approved these changes
Dec 19, 2024
| mappedBySigner[entry.signer] = entry; | ||
| }); | ||
|
|
||
| // Get the program authority's entry first, then the trusted signers |
There was a problem hiding this comment.
Would it make sense to get these already sorted from the API? Would make this easier to implement for other explorers
There was a problem hiding this comment.
I think it's fair to ask explorers to sort the results because each one is responsible for deciding what "verified" means to them.
app/utils/verified-builds.tsx
Outdated
| ...osecInfo, | ||
| message, | ||
| signer: osecInfo?.signer || '', | ||
| verification_status: VerificationStatus.Verified, |
There was a problem hiding this comment.
Is this always VerificationStatus.Verified or could it also not be verified? I think this would need to come from the osecInfo?
There was a problem hiding this comment.
Great catch! Patched!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified Build information was susceptible to a "griefing" attack disclosed by security firm Accretion. The vulnerability stemmed from the fact that anyone could overwrite verified build information in the OSec API by providing a more recent verified build information. This allowed malicious actors to overwrite protocol's GitHub repo url in the OSec API.
This has now been patched by OtterSec. The fix requires that program developers write their verified build arguments on-chain using their program authority.
For previously verified programs, their verification information was uploaded by the OSec team. However, to update previously verified information, teams must deploy their verified build information onchain.
For teams using multisig program authorities, we've described a process to prepare this transaction using
solana-verifyv0.4.0here: https://solana.com/developers/guides/advanced/verified-builds#how-to-verify-your-program-when-its-controlled-by-a-multisig-like-squads