-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add API documentation generation with TypeDoc #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add TypeDoc configuration for @solana/client package - Add docs and docs:json scripts for generating API documentation - Add CI workflow to build and publish docs to GitHub Pages - Generate markdown and JSON API specs from TypeScript/JSDoc - Add docs task to turbo.json Closes solana-foundation#85
GuiBibeau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think deploying to github pages is not needed for now, we need the code to get the typedocs done but we'll have another place to export them soon
- Remove workflow_dispatch trigger - Remove GitHub Pages deployment job - Keep TypeDoc generation with artifact upload - Docs will be deployed to solana.com in future PR
|
Thanks for the feedback! I've updated the workflow:
Ready for re-review! |
|
Incredible! Can you generate a patch changeset for this and we'll ship it? @N-45div |
I have added the same ! |
Summary
Adds TypeDoc-based API documentation generation for the
@solana/clientpackage, addressing #85.Changes
docsanddocs:jsonfor generating API documentationdocsanddocs:jsontasksGenerated Output
api.json(1.4MB) for tooling integrationHow to Test Locally
pnpm install pnpm --filter @solana/client build pnpm --filter @solana/client docs # Check packages/client/docs/Closes #85