Skip to content

Correct the return type of simulateTransaction when accounts are not loaded #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Correct the return type of simulateTransaction when accounts are not loaded #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-cars-knock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@solana/rpc-api': patch
---

Fixed a TypeScript error where the return value of `simulateTransaction` claimed there was an `accounts` property at the top level when it is in fact `value.accounts`
4 changes: 2 additions & 2 deletions packages/rpc-api/src/simulateTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export interface SimulateTransactionApi extends RpcApiMethods {
simulateTransaction(
base58EncodedWireTransaction: Base58EncodedBytes,
config?: SigVerifyAndReplaceRecentBlockhashConfig & SimulateTransactionConfigBase,
): SimulateTransactionApiResponseBase & { accounts: null };
): SimulateTransactionApiResponseBase & SolanaRpcResponse<{ readonly accounts: null }>;
Copy link
Contributor

@buffalojoec buffalojoec Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this points out a broader issue.

In lots of places, we're including the RpcResponse wrapper in the "base response", but in others, we do something like:

RpcResponse<Base & { ... }>

I think it should always be the latter. I'll make a note to comb for this in my pass over RPC stuff.


/** Simulate sending a transaction */
simulateTransaction(
Expand Down Expand Up @@ -160,5 +160,5 @@ export interface SimulateTransactionApi extends RpcApiMethods {
simulateTransaction(
base64EncodedWireTransaction: Base64EncodedWireTransaction,
config: SigVerifyAndReplaceRecentBlockhashConfig & SimulateTransactionConfigBase & { encoding: 'base64' },
): SimulateTransactionApiResponseBase & { accounts: null };
): SimulateTransactionApiResponseBase & SolanaRpcResponse<{ readonly accounts: null }>;
}