Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Use u64 for Token-Group Interface max_size #7061

Closed
jacksondoherty opened this issue Jul 28, 2024 · 3 comments · Fixed by #7130
Closed

Feature Request: Use u64 for Token-Group Interface max_size #7061

jacksondoherty opened this issue Jul 28, 2024 · 3 comments · Fixed by #7130
Labels
good first issue Good for newcomers

Comments

@jacksondoherty
Copy link
Contributor

Although they don't exist today, there are conceivable NFT projects that could have billions of members, especially with compression. For example, a project I'm working on called Garden will have a total possible supply of ~64B, which doesn't fit in u32. Unless there is a significant benefit to using u32 that I'm not aware of, we should use the maximum type here.
@buffalojoec
Copy link
Contributor

I'm not opposed to it. PRs welcome! I think the tricky bit is working with the extension state layout's alignment.

@jacksondoherty
Copy link
Contributor Author

Will look into making a PR 👍

@buffalojoec buffalojoec added the good first issue Good for newcomers label Jul 29, 2024
@jacksondoherty jacksondoherty mentioned this issue Aug 11, 2024
Merged
@jacksondoherty
Copy link
Contributor Author

PR submitted here: #7130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

token-group: Increase max size type to u64 garden-labs/solana-program-library
2 participants
@jacksondoherty @buffalojoec