Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary-option: Fixed three integer overflows #3121

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

zhaogang92
Copy link
Contributor

This PR fixed three integer overflows that have been confirmed. If there're any other actions I need to take, please let me know. Thanks!

@mergify mergify bot added the community Community contribution label Apr 27, 2022
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Any chance you can also commit the tests you used to confirm these issues?

binary-option/program/src/state.rs Outdated Show resolved Hide resolved
Change error type to AmountOverflow.

Co-authored-by: Jon Cinque <jon.cinque@gmail.com>
@joncinque joncinque merged commit 8922d20 into solana-labs:master Dec 8, 2022
HaoranYi pushed a commit to HaoranYi/solana-program-library that referenced this pull request Jul 19, 2023
* Fixed three integer overflows in binary-option

* Update binary-option/program/src/state.rs

Change error type to AmountOverflow.

Co-authored-by: Jon Cinque <jon.cinque@gmail.com>

Co-authored-by: Jon Cinque <jon.cinque@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants