Governance: MultiChoice type Weighted #3721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochaloup
force-pushed
the
weighted-choice
branch
from
8afc7d1
to
78d7cfc
Compare
|
The PR was updated to not mixing changes of the new |
ochaloup
force-pushed
the
weighted-choice
branch
4 times, most recently
from
998c652
to
cff7e77
Compare
ochaloup
force-pushed
the
weighted-choice
branch
2 times, most recently
from
62c7181
to
9e01a9a
Compare
ochaloup
force-pushed
the
weighted-choice
branch
from
9e01a9a
to
e6ced72
Compare
ochaloup
force-pushed
the
weighted-choice
branch
2 times, most recently
from
e25ef55
to
8dbdf93
Compare
ochaloup
force-pushed
the
weighted-choice
branch
from
8dbdf93
to
4f90a7e
Compare
SebastianBor
reviewed
Feb 9, 2023
ochaloup
commented
Feb 15, 2023
There was a problem hiding this comment.
@SebastianBor I adjusted the PR and verified the math as discussed.
I hope the PR would be fine for full review round.
ochaloup
changed the title
ochaloup
force-pushed
the
weighted-choice
branch
from
4f90a7e
to
2a01031
Compare
ochaloup
commented
Mar 27, 2023
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
joncinque
reviewed
Mar 30, 2023
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sebastian.Bor <sebastian_bor@hotmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of
Weightedmulti choice vote type. The implementation makes theMultiChoiceVoteTypeto be of eitherApprovaltype (existing behaviour) orWeightedthat makes possible to vote with percentage of the full vote weight.Backward compatibility notes
The change is not backward compatible for multi choice proposals. However the option has never been exposed in the UI and hence hasn't been used. In case there is an unknown instance of spl-gov which uses it it would only affect historical proposals which couldn't be loaded