Governance: voting_cool_off_time #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschneider
reviewed
Nov 19, 2022
mschneider
reviewed
Nov 19, 2022
mschneider
reviewed
Nov 19, 2022
joncinque
reviewed
Nov 21, 2022
mschneider
reviewed
Nov 24, 2022
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
* wip: add voting_cool_off_time * feat: Default voting_cool_off_time to 1h for 10h or longer votes * wip: Assert valid voting cool of time * chore: cleanup GovernanceConfig tests * chore: Rename vote_end_time() to expected_vote_end_time() * chore: test_cast_council_veto_vote_within_cool_off_time * chore: test_cast_approve_vote_with_cannot_vote_in_cool_off_time_error * chore: test_change_yes_vote_to_no_within_cool_off_time * chore: Reorder GovernanceConfig fields * chore: test_finalize_vote_with_cannot_finalize_during_cool_off_time_error * fix: Remove default voting_cool_off_time * fix: Use max = base + cool_off voting time setup * chore: Cleanup * chore: Fix test_change_yes_vote_to_no_within_cool_off_time * chore: Adjust base, cool off and max voting time names * chore: Create has_voting_base_time_ended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce voting cool of time to add an extra time when
Communityand/orCouncilcan disapprove or veto proposals.Implementation Details
max_voting_time>10hdefault to1hcool of time. The setting can be further adjusted or removed via config change proposal.EarlyorStricttipping rules.