Expose more types from CMT #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eserializing accounts.
|
Looks great. Thanks Austin! |
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
* Expose other types from CMT to allow usage on the client side while deserializing accounts. * adds a convenient creation slot getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexing CMT is made difficult without additional types.
Consider when needing to ensure we have not missed a tree while indexing. We will need an account data source.
If we get the raw account data and deserialize it into a
ConcurrentMerkleTreeHeaderwe will not be able to introspect the data version or event the account type.This pr exposes new types and bumps the version. Please consider this contribution as it could be a blocker to the additional layer of merkle tree backfilling needed for Metaplex Read API.
I also add a
get_creation_sloton the Main header struct as a convenience feature as I'm relatively sure that information will be present in all data versions.