Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stake-pool: Remove some unwraps #4003

Merged
merged 3 commits into from
Jan 28, 2023
Merged

Conversation

joncinque
Copy link
Contributor

Problem

There's some unwraps in the stake pool program, which can cause issues.

Solution

Remove a couple of them. When trying to remove the ones from active_lamports_greater_than and transient_lamports_greater_than, it increased compute usage so much that the max pool size went down to 2500, so it's not worth removing all of them.

@joncinque joncinque merged commit 2cdef76 into solana-labs:master Jan 28, 2023
@joncinque joncinque deleted the sp-unwrap branch January 28, 2023 01:13
HaoranYi pushed a commit to HaoranYi/solana-program-library that referenced this pull request Jul 19, 2023
* stake-pool: Remove a couple of unwraps

* Remove one more unwrap

* Update CLI too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant