This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
[token-client] use Signersinstead of Signer for confidential transfer client functions
#7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some confidential transfer related functions in the token-client take in
Signerinstead ofSignersas is done in other token-client functions.Summary of Changes
I updated these functions to take in
Signersto be in-line with the rest of the functions. The only exception isconfidential_transfer_create_record_account. This function creates multiple transactions and they might require differing list of signers. Therefore, for this function, I ended up updating the parameters so that the different signers could be of differing type (previously, they had to be the same type, e.g. both signers have to be keypairs).