This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
remove solana-program from token-metadata-interface #7431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Oct 31, 2024
token-metadata/interface/Cargo.toml
Outdated
| solana-borsh = "2.1.0" | ||
| solana-decode-error = "2.1.0" | ||
| solana-instruction = "2.1.0" | ||
| solana-msg = "2.1.0" | ||
| solana-program = "2.1.0" |
There was a problem hiding this comment.
Can we go with the same approach here and just re-export the crates that it uses? It looks like that's the only usage of solana-program in the crate, so we can remove it after that
kevinheavey
force-pushed
the
token-metadata-interface-rm-program
branch
from
5af84ce to
a4ddf63
Compare
joncinque
approved these changes
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some imports and replaced spl-program-error with inlining