This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
record: Remove dependency on solana-program #7445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem It's possible to write programs without solana-program, but spl-record still has a dependency on it. #### Summary of changes Mostly straightforward, replacing the crates with their components. I also removed a dependency on spl-pod, because that brings in solana-zk-sdk, which does require solana-program currently.
samkim-crypto
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Looks good to me! solana-program is now removed from zk-sdk as well (anza-xyz/agave#3409), but that is not included in 2.1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible to write programs without solana-program, but spl-record still has a dependency on it.
Summary of changes
Mostly straightforward, replacing the crates with their components. I also removed a dependency on spl-pod, because that brings in solana-zk-sdk, which does require solana-program currently.
Compile times on my local machine go down from ~16s to less than ~4s 🥳