This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
[token22] Avoid the use of extend_from_slice when appending instructions
#7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
This is relevant when building the token22 program for wasm target. The Instruction type implements Clone for non-wasm targets, but does not seem to implement it for wasm targets (https://github.com/anza-xyz/agave/blob/master/sdk/instruction/src/lib.rs#L108).
Bah, this looks like it was a bug introduced in anza-xyz/agave#1658 -- there's no reason we shouldn't derive those for the wasm build. I'll put a fix in there. In the meantime, this change looks good!
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Nov 13, 2024
#### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in anza-xyz#1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1.
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Nov 13, 2024
#### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in #1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1.
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Nov 13, 2024
#### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in #1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1. (cherry picked from commit d3bce9f)
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Nov 18, 2024
… (#3610) instruction: Derive everything for wasm build (#3606) #### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in #1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1. (cherry picked from commit d3bce9f) Co-authored-by: Jon C <me@jonc.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the confidential mint and burn extension, the vector of proof instructions are appended to the token instruction using the
extend_from_slicemethod, which requires the underlying element type of the slice to implement theClonetrait. Though minimal, it is better to use theextendfunction that subsumes the input vector sinceextenddoes not require the underlying element type to be implement any trait.This is relevant when building the token22 program for wasm target. The
Instructiontype implementsClonefor non-wasm targets, but does not seem to implement it for wasm targets (https://github.com/anza-xyz/agave/blob/master/sdk/instruction/src/lib.rs#L108).Summary of Changes
Replace
extend_from_slicewithextend.