Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experimental] Use optimized base16 encode strategy #2527

Closed
steveluscher opened this issue Apr 18, 2024 · 6 comments · Fixed by #2552
Closed

[experimental] Use optimized base16 encode strategy #2527

steveluscher opened this issue Apr 18, 2024 · 6 comments · Fixed by #2552
Labels
enhancement New feature or request released

Comments

@steveluscher
Copy link
Collaborator

This is apparently way faster than what we're doing here: paulmillr/noble-curves#83
@steveluscher steveluscher added the enhancement New feature or request label Apr 18, 2024
@steveluscher
Copy link
Collaborator Author

Are you interested in fixing this one too @arobsn?

tibi77 added a commit to tibi77/solana-web3.js that referenced this issue Apr 23, 2024
@tibi77
fix solana-labs#2527
f169970
@tibi77 tibi77 mentioned this issue Apr 23, 2024
Merged
@tibi77
Copy link
Contributor

tibi77 commented Apr 23, 2024

@steveluscher i did push a pr for this Issue, but i m unsure how we can test it

@tibi77
Copy link
Contributor

tibi77 commented Apr 23, 2024

i m not reffering to the correctness of the code, but rather to the improve in speed

tibi77 added a commit to tibi77/solana-web3.js that referenced this issue Apr 24, 2024
@tibi77
fix solana-labs#2527
040199b
@mergify mergify bot closed this as completed in #2552 Apr 26, 2024
mergify bot pushed a commit that referenced this issue Apr 26, 2024
@tibi77 @steveluscher
[refactor] [experimental] Use optimised base16 encode strategy (#2552)
0aa3717 
* fix #2527

* base16 encode benchmark

* fix pnpx vs pnpm exec

* Performance and code compactness nits

* Run `style:fix`

---------

Co-authored-by: steveluscher <me+github@steveluscher.com>
steveluscher added a commit that referenced this issue Apr 26, 2024
@tibi77 @steveluscher
[refactor] [experimental] Use optimised base16 encode strategy (#2552)
bea43ef 
* fix #2527

* base16 encode benchmark

* fix pnpx vs pnpm exec

* Performance and code compactness nits

* Run `style:fix`

---------

Co-authored-by: steveluscher <me+github@steveluscher.com>
@arobsn
Copy link

arobsn commented Apr 30, 2024

Are you interested in fixing this one too @arobsn?

Oh, didn't see the notification, sorry. Happy you guys have this fixed now :)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

🎉 This issue has been resolved in version 1.91.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] [experimental] Use optimised base16 encode strategy tibi77/solana-web3.js
3 participants
@steveluscher @tibi77 @arobsn