This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
refactor(experimental): alias JSON-RPC types for performance #1760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tl;dr, @Dimava is a saint (link).
Breaking up the mega-overload helper into separate helpers for each level of overload fixed #1682.
Test Plan
Before (11300ms check time)
After (170ms check time)
Holy shit.
Screen.Recording.2023-10-21.at.11.08.12.PM.mov