refactor(experimental): rename Base58EncodedAddress to Address
#1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
steveluscher
deleted the
11-07-refactor_experimental_rename_Base58EncodedAddress_to_Address_
branch
|
🎉 This PR is included in version 1.87.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To make this API more terse, we're going to take the default type of addresses (the base-58 encoded one) and name it simply
Address. Specific types of addresses will be given names likeAddressBytesandAddressBase64but the conventional one will not carry a specifier.This was basically a find-and-replace with some light spot checking for grammar (eg. ‘a
Base58EncodedAddress’ => ‘anAddress.’This change was brought to you by bikeshedding on Twitter. https://twitter.com/lorismatic/status/1710595018170245603
Test Plan