refactor(experimental): a createPrivateKeyFromBytes helper
#1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
steveluscher
force-pushed
the
11-30-refactor_experimental_a_createPrivateKeyFromBytes_helper
branch
from
d0c4937 to
883da3d
Compare
steveluscher
deleted the
11-30-refactor_experimental_a_createPrivateKeyFromBytes_helper
branch
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes you just have the bytes already, but you don't want to have to futz with crafting your own PKCS#8 payload. This helper will do it for you.
Note: I left the PKCS#8 header alone in the polyfill, because it's designed to eventually go away.
Test Plan
Closes #1813.