-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(experimental): add read write functions to option codecs #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2023
lorisleiva
force-pushed
the
loris/rename-is-fixed-helpers
branch
from
December 1, 2023 09:47
5314f95
to
b2f08a6
Compare
lorisleiva
force-pushed
the
loris/refactor-options
branch
from
December 1, 2023 09:47
7a8e953
to
38fe2c9
Compare
buffalojoec
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
mcintyre94
approved these changes
Dec 1, 2023
Merge activity
|
lorisleiva
force-pushed
the
loris/rename-is-fixed-helpers
branch
from
December 1, 2023 15:24
b2f08a6
to
fcbb84a
Compare
lorisleiva
force-pushed
the
loris/refactor-options
branch
from
December 1, 2023 15:25
38fe2c9
to
4bd2da1
Compare
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We continue the codecs refactoring, this time in the
options
package.