Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experimental): add read write functions to option codecs #1920

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

lorisleiva
Copy link
Contributor

We continue the codecs refactoring, this time in the options package.

Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor Author

lorisleiva commented Dec 1, 2023

Merge activity

  • Dec 1, 10:16 AM: @lorisleiva started a stack merge that includes this pull request via Graphite.
  • Dec 1, 10:25 AM: Graphite rebased this pull request as part of a merge.
  • Dec 1, 10:26 AM: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva force-pushed the loris/rename-is-fixed-helpers branch from b2f08a6 to fcbb84a Compare December 1, 2023 15:24
Base automatically changed from loris/rename-is-fixed-helpers to master December 1, 2023 15:25
@lorisleiva lorisleiva force-pushed the loris/refactor-options branch from 38fe2c9 to 4bd2da1 Compare December 1, 2023 15:25
@lorisleiva lorisleiva merged commit 5b7e1d3 into master Dec 1, 2023
4 of 6 checks passed
@lorisleiva lorisleiva deleted the loris/refactor-options branch December 1, 2023 15:26
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants