Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all rpc-method XApi types from rpc-core #1965

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

mcintyre94
Copy link
Contributor

  • We previously exported some of these, only those used by our other packages
  • The readme showing how to narrow the scope of the RPC did so by importing from @solana/rpc-core/dist/types/...

This PR updates the export to include all the XApi types
This allows narrowing the scope of the RPC to any combination of APIs without needing to import from dist/types

Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

packages/library/README.md Outdated Show resolved Hide resolved
@buffalojoec
Copy link
Contributor

heh #1948

@mcintyre94 mcintyre94 merged commit ed98b3d into master Dec 11, 2023
6 checks passed
@mcintyre94 mcintyre94 deleted the export-rpc-core-apis branch December 11, 2023 17:12
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants