Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(experimental): add ClusterUrl types #2084

Merged
merged 1 commit into from
Feb 2, 2024
Merged

refactor(experimental): add ClusterUrl types #2084

merged 1 commit into from
Feb 2, 2024

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Feb 1, 2024 •
edited
Loading

As per @lorisleiva's suggestion, here's some types for cluster URLs!
Straight from this comment

This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Closed
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Feb 1, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Feb 1, 2024
Closed
Closed
@mergify mergify bot added the community label Feb 1, 2024
@buffalojoec buffalojoec force-pushed the 01-31-refactor_experimental_add_ClusterUrl_types branch from 0dc7a6d to f883a80 Compare February 1, 2024 21:27
@buffalojoec buffalojoec force-pushed the 01-31-refactor_experimental_add_ClusterUrl_types branch from f883a80 to c9bb45e Compare February 2, 2024 15:58
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Feb 2, 2024 •
edited
Loading

Merge activity

@buffalojoec buffalojoec merged commit 61f7ba0 into master Feb 2, 2024
10 checks passed
@buffalojoec buffalojoec deleted the 01-31-refactor_experimental_add_ClusterUrl_types branch February 2, 2024 16:36
steveluscher
steveluscher reviewed Feb 2, 2024
View reviewed changes
packages/rpc-types/src/cluster-url.ts
export type TestnetUrl = string & { '~cluster': 'testnet' };
export type ClusterUrl = string | MainnetUrl | DevnetUrl | TestnetUrl;

export function mainnet(putativeString: string): MainnetUrl {
Copy link
Collaborator

@steveluscher steveluscher Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit regarding my favorite word to use in code. This is usually the word I use for assertion functions (ie. ones whose return type is foo is Bar). Putative means ‘supposed’ or ‘assumed to exist.’

This puppy doesn't make any assertions; it's just a typecast utility. mainnet(url: string): MainnetUrl would do fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your favorite word in code? What about foo? Personally, mine is console.log("FLARE"), but that never gets committed :).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

🎉 This PR is included in version 1.90.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher left review comments

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees
No one assigned
Labels
community released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buffalojoec @steveluscher @lorisleiva