This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
draft: account errors #2183
Closed
draft: account errors #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
Also, I'm not sure exactly which characters the A-Z idea you're referencing in #2118 @steveluscher. |
|
This looks great IMO. |
This was referenced Feb 24, 2024
This was referenced Feb 28, 2024
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: NOT FOR MERGE: How's this looking?
I'm not sure if we want to stay consistent with any error enums from the SDK,
but here's a first brush at adding
SolanaErrorcodes to@solana/accounts.If we are decoupling from the SDK, then providing pluralized errors might help
with this package.