This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Convert all errors in @solana/rpc-types to coded exceptions
#2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
f0ad0e1 to
75de449
Compare
steveluscher
force-pushed
the
03-01-Convert_all_errors_in_solana/rpc-types_to_coded_exceptions
branch
from
fa52ec1 to
91d267b
Compare
steveluscher
commented
Mar 1, 2024
Comment on lines
-16
to
-23
| if (putativeLamports < 0) { | ||
| // TODO: Coded error. | ||
| throw new Error('Input for 64-bit unsigned integer cannot be negative'); | ||
| } | ||
|
|
||
| if (putativeLamports > maxU64Value) { | ||
| // TODO: Coded error. | ||
| throw new Error('Input number is too large to be represented as a 64-bit unsigned integer'); |
There was a problem hiding this comment.
Sort of figured these both boiled down to ‘out of range.’
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
75de449 to
e14a7ef
Compare
steveluscher
force-pushed
the
03-01-Convert_all_errors_in_solana/rpc-types_to_coded_exceptions
branch
from
91d267b to
a583373
Compare
lorisleiva
approved these changes
Mar 1, 2024
packages/errors/src/codes.ts
Outdated
Comment on lines
57
to
58
| export const SOLANA_ERROR__BIGINT_STRING_MALFORMED = 51 as const; | ||
| export const SOLANA_ERROR__NUMBER_STRING_MALFORMED = 52 as const; |
There was a problem hiding this comment.
nit: We may want to stay consistent with other existing error names such as SOLANA_ERROR__MALFORMED_PROGRAM_DERIVED_ADDRESS and use MALFORMED as a prefixed instead of a suffix.
Unless we prefer the suffix version, in which case we should probably update the other ones.
steveluscher
force-pushed
the
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
branch
from
e14a7ef to
3b46917
Compare
steveluscher
force-pushed
the
03-01-Convert_all_errors_in_solana/rpc-types_to_coded_exceptions
branch
from
a583373 to
4ee6090
Compare
Merge activity
|
Base automatically changed from
02-29-Convert_errors_in_solana/signers_to_coded_exceptions
to
master
March 1, 2024 22:48
steveluscher
force-pushed
the
03-01-Convert_all_errors_in_solana/rpc-types_to_coded_exceptions
branch
from
4ee6090 to
696be96
Compare
steveluscher
deleted the
03-01-Convert_all_errors_in_solana/rpc-types_to_coded_exceptions
branch
|
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2118.