Convert all errors in @solana/rpc-subscriptions-* to coded exceptions
#2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
commented
Mar 2, 2024
| // TODO: Coded error. | ||
| throw new Error('WebSocket connection closed', { cause: e }); | ||
| throw new SolanaError(SOLANA_ERROR__RPC_WEBSOCKET_TRANSPORT_CONNECTION_CLOSED, { | ||
| cause: e, |
There was a problem hiding this comment.
This is the reason for #2235.
steveluscher
force-pushed
the
03-01-Convert_all_errors_in_solana/rpc-subscriptions-_to_coded_exceptions
branch
from
4d5c576 to
041950e
Compare
lorisleiva
reviewed
Mar 2, 2024
packages/errors/src/codes.ts
Outdated
Comment on lines
62
to
64
| export const SOLANA_ERROR__RPC_WEBSOCKET_TRANSPORT_CLOSED_BEFORE_MESSAGE_BUFFERED = 56 as const; | ||
| export const SOLANA_ERROR__RPC_WEBSOCKET_TRANSPORT_CONNECTION_CLOSED = 57 as const; | ||
| export const SOLANA_ERROR__RPC_WEBSOCKET_TRANSPORT_FAILED_TO_CONNECT = 58 as const; |
There was a problem hiding this comment.
How would you feel about prefixing RPC Subscriptions errors with RPC_SUBSCRIPTIONS and following the same convention as RPC_TRANSPORT_HTTP — i.e. the concrete name of the transport come after the abstract name of the interface. Something like:
// Before.
SOLANA_ERROR__RPC_WEBSOCKET_TRANSPORT_CLOSED_BEFORE_MESSAGE_BUFFERED
SOLANA_ERROR__RPC_WEBSOCKET_TRANSPORT_CONNECTION_CLOSED
SOLANA_ERROR__RPC_WEBSOCKET_TRANSPORT_FAILED_TO_CONNECT
SOLANA_ERROR__SUBSCRIPTION_EXPECTED_SERVER_SUBSCRIPTION_ID
SOLANA_ERROR__SUBSCRIPTION_CANNOT_CREATE_SUBSCRIPTION_REQUEST
// After.
SOLANA_ERROR__RPC_SUBSCRIPTIONS_TRANSPORT_WEBSOCKET_CLOSED_BEFORE_MESSAGE_BUFFERED
SOLANA_ERROR__RPC_SUBSCRIPTIONS_TRANSPORT_WEBSOCKET_CONNECTION_CLOSED
SOLANA_ERROR__RPC_SUBSCRIPTIONS_TRANSPORT_WEBSOCKET_FAILED_TO_CONNECT
SOLANA_ERROR__RPC_SUBSCRIPTIONS_EXPECTED_SERVER_SUBSCRIPTION_ID
SOLANA_ERROR__RPC_SUBSCRIPTIONS_CANNOT_CREATE_SUBSCRIPTION_REQUESTI also think the first three should probably live under the subscription-related error codes. Unless I'm missing something.
steveluscher
force-pushed
the
03-02-_SolanaError_now_supports_the_cause_property
branch
from
e969a10 to
8516be1
Compare
steveluscher
force-pushed
the
03-01-Convert_all_errors_in_solana/rpc-subscriptions-_to_coded_exceptions
branch
from
041950e to
72dde8f
Compare
Merge activity
|
Base automatically changed from
03-02-_SolanaError_now_supports_the_cause_property
to
master
March 4, 2024 03:02
steveluscher
force-pushed
the
03-01-Convert_all_errors_in_solana/rpc-subscriptions-_to_coded_exceptions
branch
from
72dde8f to
70cdcb5
Compare
steveluscher
deleted the
03-01-Convert_all_errors_in_solana/rpc-subscriptions-_to_coded_exceptions
branch
steveluscher
added a commit
that referenced
this pull request
Mar 4, 2024
steveluscher
added a commit
that referenced
this pull request
Mar 4, 2024
|
🎉 This PR is included in version 1.91.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.