This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
refactor(experimental): improve getTupleCodec type inferences #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5cf4020 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @lorisleiva and the rest of your teammates on |
lorisleiva
force-pushed
the
loris/improve-tuple-inference
branch
from
248f04d to
d116532
Compare
lorisleiva
force-pushed
the
loris/improve-tuple-inference
branch
from
d116532 to
de73851
Compare
buffalojoec
approved these changes
Mar 19, 2024
lorisleiva
force-pushed
the
loris/codec-drain-outer-generic
branch
from
b8caa96 to
e6d76e0
Compare
lorisleiva
force-pushed
the
loris/improve-tuple-inference
branch
from
de73851 to
87e679c
Compare
lorisleiva
force-pushed
the
loris/codec-drain-outer-generic
branch
from
e6d76e0 to
d309da8
Compare
lorisleiva
force-pushed
the
loris/improve-tuple-inference
branch
from
87e679c to
84e4286
Compare
Merge activity
|
lorisleiva
force-pushed
the
loris/improve-tuple-inference
branch
from
84e4286 to
5cf4020
Compare
|
🎉 This PR is included in version 1.91.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 26, 2024
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the footsteps of #2181 which improved the type inferences of
getStructCodecandgetDataEnumCodecby inferring the types from the provided codecs instead of inferring the other way around.This PR does the same with the
getTupleCodecand also makes use of theDrainOuterGenerichelper from the previous PR to reduce the amount of instantiations TypeScript does when resolving the codec types.