Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete lots of transactions code! #2494

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Delete lots of transactions code! #2494

merged 1 commit into from
Apr 18, 2024

Conversation

mcintyre94
Copy link
Contributor

@mcintyre94 mcintyre94 commented Apr 16, 2024

FINALLY!

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 4abb0dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stack isn't finish though right? We still need to rename a few things and remove the New prefixes IIRC.

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@mcintyre94 mcintyre94 force-pushed the tx-refactor-types-usages branch from 0efa2d9 to 953ba14 Compare April 18, 2024 06:26
@mcintyre94
Copy link
Contributor Author

@lorisleiva Yep, you're right - deleting all this stuff is the prerequisite to being able to re-use the names

@mcintyre94 mcintyre94 force-pushed the tx-refactor-types-usages branch from 953ba14 to d9e6623 Compare April 18, 2024 07:27
Base automatically changed from tx-refactor-types-usages to master April 18, 2024 07:29
Copy link
Contributor

🎉 This PR is included in version 1.91.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented May 3, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants