Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use our version of fast-stable-stringify everywhere #2504

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: use our version of fast-stable-stringify everywhere #2504

merged 2 commits into from
Apr 17, 2024

Conversation

steveluscher
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 14a7e38

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Apr 17, 2024
Merged
Merged
Merged
@steveluscher Graphite App
Copy link
Collaborator Author

steveluscher commented Apr 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

steveluscher
steveluscher commented Apr 17, 2024
View reviewed changes
packages/library-legacy/src/connection.ts
@@ -6291,10 +6290,7 @@
args: IWSRequestParams,
): ClientSubscriptionId {
const clientSubscriptionId = this._nextClientSubscriptionId++;
const hash = fastStableStringify(
[subscriptionConfig.method, args],
true /* isArrayProp */,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this never did anything. TypeScript passed because this function used to be any.

@steveluscher steveluscher force-pushed the 04-16-format_readme_of_solana_fast-stable-stringify_ branch from f60f9d8 to 2e7e34e Compare April 17, 2024 00:52
@steveluscher steveluscher force-pushed the 04-16-use_our_version_of_fast-stable-stringify_everywhere branch from 33bea44 to 107739b Compare April 17, 2024 00:52
@steveluscher steveluscher force-pushed the 04-16-format_readme_of_solana_fast-stable-stringify_ branch from 2e7e34e to 5b7163a Compare April 17, 2024 01:01
@steveluscher steveluscher force-pushed the 04-16-use_our_version_of_fast-stable-stringify_everywhere branch from 107739b to 25fb51f Compare April 17, 2024 01:01
lorisleiva
lorisleiva approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the @solana/* only dependencies!

@steveluscher steveluscher changed the title Use our version of fast-stable-stringify everywhere fix: use our version of fast-stable-stringify everywhere Apr 17, 2024
@steveluscher Graphite App
Copy link
Collaborator Author

steveluscher commented Apr 17, 2024 •
edited
Loading

Merge activity

  • Apr 17, 12:36 AM PDT: @steveluscher started a stack merge that includes this pull request via Graphite.
  • Apr 17, 12:42 AM PDT: Graphite rebased this pull request as part of a merge.
  • Apr 17, 12:43 AM PDT: @steveluscher merged this pull request with Graphite.

@steveluscher steveluscher force-pushed the 04-16-format_readme_of_solana_fast-stable-stringify_ branch from 5b7163a to 0199cc9 Compare April 17, 2024 07:39
Base automatically changed from 04-16-format_readme_of_solana_fast-stable-stringify_ to master April 17, 2024 07:41
@steveluscher steveluscher force-pushed the 04-16-use_our_version_of_fast-stable-stringify_everywhere branch from 25fb51f to 14a7e38 Compare April 17, 2024 07:41
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/jest-runner-eslint@2.2.0 Transitive: environment, filesystem, shell +11 318 kB simenb
npm/jest-runner-prettier@1.0.0 Transitive: environment, eval, filesystem, network, shell, unsafe +140 17.9 MB keplersj
npm/jest-watch-master@1.0.0 Transitive: environment +12 331 kB rickhanlonii
npm/jest-watch-select-projects@2.0.0 None +5 108 kB simenb
npm/jest-watch-typeahead@2.2.2 Transitive: environment, filesystem, unsafe +27 565 kB simenb
npm/jest-websocket-mock@2.5.0 None +7 328 kB romgain
npm/jest@30.0.0-alpha.3 Transitive: environment, eval, filesystem, network, shell, unsafe +144 12.4 MB simenb

🚮 Removed packages: npm/@solana/accounts@2.0.0-preview.2, npm/@solana/addresses@2.0.0-preview.2, npm/@solana/assertions@2.0.0-preview.2, npm/@solana/codecs-core@2.0.0-preview.2, npm/@solana/codecs-data-structures@2.0.0-preview.2, npm/@solana/codecs-numbers@2.0.0-preview.2, npm/@solana/codecs-strings@2.0.0-preview.2, npm/@solana/codecs@2.0.0-preview.2, npm/@solana/errors@2.0.0-preview.2, npm/@solana/functional@2.0.0-preview.2, npm/@solana/instructions@2.0.0-preview.2, npm/@solana/keys@2.0.0-preview.2, npm/@solana/options@2.0.0-preview.2, npm/@solana/programs@2.0.0-preview.2, npm/@solana/rpc-api@2.0.0-preview.2, npm/@solana/rpc-parsed-types@2.0.0-preview.2, npm/@solana/rpc-spec-types@2.0.0-preview.2, npm/@solana/rpc-spec@2.0.0-preview.2, npm/@solana/rpc-subscriptions-api@2.0.0-preview.2, npm/@solana/rpc-subscriptions-spec@2.0.0-preview.2, npm/@solana/rpc-subscriptions-transport-websocket@2.0.0-preview.2, npm/@solana/rpc-subscriptions@2.0.0-preview.2, npm/@solana/rpc-transformers@2.0.0-preview.2, npm/@solana/rpc-transport-http@2.0.0-preview.2, npm/@solana/rpc-types@2.0.0-preview.2, npm/@solana/rpc@2.0.0-preview.2, npm/@solana/signers@2.0.0-preview.2, npm/@solana/transaction-confirmation@2.0.0-preview.2, npm/@solana/transactions@2.0.0-preview.2, npm/@solana/web3.js@0.0.0-development

View full report↗︎

@steveluscher steveluscher merged commit 18d6b56 into master Apr 17, 2024
6 checks passed
@steveluscher steveluscher deleted the 04-16-use_our_version_of_fast-stable-stringify_everywhere branch April 17, 2024 07:43
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.91.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ZhengYuTay
Copy link

@steveluscher seems like it cause npm installed to fail, the dep wasnt replaced with a published version when published
image

@solanamonk
Copy link

I believe this PR broke the package.

$ pnpm update @solana/web3.js
 ERR_PNPM_WORKSPACE_PKG_NOT_FOUND  In : "@solana/fast-stable-stringify@workspace:*" is in the dependencies but no package named "@solana/fast-stable-stringify" is present in the workspace

This error happened while installing the dependencies of @solana/web3.js@1.91.5

Packages found in the workspace: 
Progress: resolved 68, reused 69, downloaded 0, added 0

@steveluscher Graphite App
Copy link
Collaborator Author

Thanks for the report. 1.91.5 is deprecated now. Apparently semantic-release doesn't use or resolve pnpm workspace references when publishing.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steveluscher @ZhengYuTay @solanamonk @lorisleiva