-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(library-legacy/deps): rpc-websockets@^7.11.0->^7.11.1 #2758
Conversation
|
@legobeat please check this issue #2762 In elpheria/rpc-websockets#161 they renamed files and now imports in solana-web3 package work incorrect. We should or update imports or set fixed version of |
@uafrontender Indeed. That's what this PR fixes. |
Can you explain how does it fix? The problem arose because solana-web3 does not use a strict version of rpc-websockets, like 7.11.0. Instead, it uses ^7.11.0, which allows npm to install last compatible version, including 7.11.1. The 7.11.1 version of rpc-websockets was updated yesterday and is not compatible with the current code of solana-web3. @legobeat actually your PR changes nothing because now after I run |
779dbba
to
88982b5
Compare
Sorry for the dismissiveness 🤦 Pushed again with the actual fix.
Actually, actually not (look at the lockfile) ;). From a perspective of user of the package; it depends which of the two you end up with. But that's kind of besides the main point of making sure the actual issue fixed, which you rightly addressed! |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls fix |
fb37c50
to
5090f02
Compare
🎉 This PR is included in version 1.91.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please consider using a fixed version from rpc-websockets to prevent any upcoming breaking changes again. Can we have the workaround in description?
|
@steveluscher This issue still persists in my Nextjs Pages router project, what should I do? |
Do you have a repro you can send me? |
Upstream later deprecated |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
rpc-websockets@7.11.0
is broken and deprecated. This upgrades to fixed7.11.1
.