Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Add createKeyPairSignerFromPrivateKeyBytes helper #3051

Merged

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Aug 2, 2024

This PR adds a createKeyPairSignerFromPrivateKeyBytes helper that compose createKeyPairFromPrivateKeyBytes and createSignerFromKeyPair.

It also adds missing documentation for the createKeyPairSignerFromBytes function.

Copy link

changeset-bot bot commented Aug 2, 2024

🦋 Changeset detected

Latest commit: a5fec8b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva lorisleiva changed the title Add createKeyPairSignerFromPrivateKeyBytes helper Add createKeyPairSignerFromPrivateKeyBytes helper Aug 2, 2024
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from 5ef7999 to 993119b Compare August 2, 2024 14:45
@lorisleiva lorisleiva marked this pull request as ready for review August 2, 2024 14:46
@lorisleiva lorisleiva mentioned this pull request Aug 2, 2024
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@lorisleiva lorisleiva force-pushed the loris/create-keypair-from-private-key-bytes branch from cf1091d to b738776 Compare August 5, 2024 11:31
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from 993119b to e8a2dd9 Compare August 5, 2024 11:32
@lorisleiva lorisleiva force-pushed the loris/create-keypair-from-private-key-bytes branch from b738776 to 8b2a00d Compare August 5, 2024 11:36
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from e8a2dd9 to 4872e7a Compare August 5, 2024 11:36
@lorisleiva lorisleiva force-pushed the loris/create-keypair-from-private-key-bytes branch from 8b2a00d to 329cf27 Compare August 5, 2024 11:45
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from 4872e7a to aa40be3 Compare August 5, 2024 11:45
@lorisleiva lorisleiva force-pushed the loris/create-keypair-from-private-key-bytes branch from 329cf27 to f180911 Compare August 5, 2024 11:51
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from aa40be3 to 2b7d98a Compare August 5, 2024 11:51
@lorisleiva lorisleiva force-pushed the loris/create-keypair-from-private-key-bytes branch from f180911 to 5de7317 Compare August 5, 2024 12:02
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from 2b7d98a to b678f4f Compare August 5, 2024 12:02
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@lorisleiva lorisleiva force-pushed the loris/create-keypair-from-private-key-bytes branch from 5de7317 to 913533a Compare August 7, 2024 08:09
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from b678f4f to 1f4938d Compare August 7, 2024 08:09
Copy link
Contributor Author

lorisleiva commented Aug 7, 2024

Merge activity

  • Aug 7, 4:34 AM EDT: @lorisleiva started a stack merge that includes this pull request via Graphite.
  • Aug 7, 4:45 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 7, 4:46 AM EDT: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/create-keypair-from-private-key-bytes to graphite-base/3051 August 7, 2024 08:41
@lorisleiva lorisleiva changed the base branch from graphite-base/3051 to master August 7, 2024 08:43
@lorisleiva lorisleiva force-pushed the loris/create-keypair-signer-from-private-key-bytes branch from 1f4938d to a5fec8b Compare August 7, 2024 08:44
@lorisleiva lorisleiva merged commit 1ad523d into master Aug 7, 2024
7 checks passed
@lorisleiva lorisleiva deleted the loris/create-keypair-signer-from-private-key-bytes branch August 7, 2024 08:46
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants