refactor(experimental): GraphQL: Refactor program accounts filters #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f7368bd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
buffalojoec
force-pushed
the
program-accounts-filters
branch
from
936f728 to
a37e7f3
Compare
buffalojoec
force-pushed
the
program-accounts-filters
branch
from
a37e7f3 to
436094e
Compare
lorisleiva
approved these changes
Aug 14, 2024
Merged
This was referenced Aug 22, 2024
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The filters input parameter for the GraphQL resolver is malformed. This PR brings it to parity with the Solana JSON RPC API as well as the
@solana/rpc-apipackage's definition for program accounts filters.Summary of Changes
First add some test coverage to
@solana/rpc-apifor program accounts filters to ensure everything is working properly.Then, refactor the GraphQL API for the
programAccountsquery to correct the program accounts filters input. Finally, add some tests for GraphQL.Since GraphQL doesn't allow unions as input types, I had to split the two types of filters into two separate filters for the GraphQL API, then coalesce them into the same
filtersargument for the RPC.