-
Notifications
You must be signed in to change notification settings - Fork 918
Conversation
🦋 Changeset detectedLatest commit: 8fde46a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2c3f4ee
to
26f7290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense for this PR to be two separate PRs. You've got a pretty clear distinction between the two in both the changeset and the READMEs.
d29ef2d
to
6a8c5ee
Compare
26f7290
to
800d312
Compare
@buffalojoec Yeah I should have done but because I'm renaming filenames in this PR, running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge activity
|
800d312
to
8fde46a
Compare
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This PR finishes the refactoring of the
getDefaultRequestTransformerForSolanaRpc
function by creating three new request transformers and delegating to them:getIntegerOverflowRequestTransformer
: Wraps the integer overflow visitor in a request transformer.getBigIntDowncastRequestTransformer
: Wraps the bigint downcast visitor in a request transformer.getTreeWalkerRequestTransformer
: Helper that creates request transformers from visitors.Additionally, this PR changes the definition of the
onIntegerOverflow
slightly by usingrequest: RpcRequest
as its first argument instead ofmethodName: string
to be more consistent with the rest of the RPC API.