Extract isJsonRpcPayload method to rpc-spec
#3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 31aa1a0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @lorisleiva and the rest of your teammates on |
lorisleiva
force-pushed
the
loris/json-stringify-with-bigints
branch
from
42cece0 to
b3c246e
Compare
lorisleiva
force-pushed
the
loris/extract-is-json-rpc-payload
branch
from
0d92cd7 to
2b4def2
Compare
Merge activity
|
This was referenced Sep 11, 2024
lorisleiva
changed the base branch from
loris/json-stringify-with-bigints
to
graphite-base/3221
lorisleiva
force-pushed
the
loris/extract-is-json-rpc-payload
branch
from
2b4def2 to
31aa1a0
Compare
Merged
This was referenced Sep 11, 2024
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts and exposes the
isJsonRpcPayloadhelper method into therpc-specpackage. This is because we're going to need this function in multiple places going forward in order to inspect in a givenunknownpayload is a JSON RPC one (with a method name and parameters).