Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename decodeTransactionMessage to decompileTransactionMessageFetchingLookupTables #3453

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

mcintyre94
Copy link
Contributor

This function had a confusing name, the new name better describes its functionality. It uses the passed in RPC to fetch lookup tables, and then passes them to decompileTransactionMessage.

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 9893cb0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@mcintyre94 mcintyre94 force-pushed the rename-decode-transaction branch from a36426a to 9893cb0 Compare October 29, 2024 17:10
@mcintyre94 mcintyre94 merged commit bafefed into master Oct 29, 2024
8 checks passed
@mcintyre94 mcintyre94 deleted the rename-decode-transaction branch October 29, 2024 17:33
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants