Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Correct type of replacementBlockhash in simulateTransaction #3454

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

mcintyre94
Copy link
Contributor

In my testing the replacementBlockhash field is returned as a blockhash lifetime, not just a blockhash:

            "replacementBlockhash": {
                "blockhash": "8cKUmRzjcBaDFnuvQT69FMQt6LQMessU57d4c6YsuUS8",
                "lastValidBlockHeight": 276255611
            },

This also matches the server code: https://github.com/anza-xyz/agave/blob/aad0381e10e3c4a6507d9aa2e57588e6dc6fc995/rpc/src/rpc.rs#L3817

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: f4ccde3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👌

Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@mcintyre94 mcintyre94 merged commit 1fde4b1 into master Oct 29, 2024
8 checks passed
@mcintyre94 mcintyre94 deleted the fix-replacement-blockhash branch October 29, 2024 15:24
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants