This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Accept bigints in RPC error factories #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ee94ba The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @lorisleiva and the rest of your teammates on |
BundleMonFiles updated (7)
Unchanged files (118)
Total files change -262B -0.08% Final result: ✅ View report in BundleMon website ➡️ |
lorisleiva
force-pushed
the
loris/accept-bigints-in-error-factories
branch
2 times, most recently
from
73aedaf to
2d5d282
Compare
steveluscher
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
I'm fine with this, but I don't think I actually understand why the numeric keypath allowlist is insufficient for this. The root data has that special case in the transport (which we could add to the subscriptions one) and for the errors-as-data (ie. instruction errors) I think we could put a keypath here:
solana-web3.js/packages/rpc-api/src/index.ts
Lines 287 to 290 in d83eaaf
Anyway, I think that what this is doing is playing fast and loose with the types, but only internal to the transport; devs will never see a bigint error code.
lorisleiva
changed the base branch from
loris/add-failing-tests-for-bigint-codes-and-indices
to
graphite-base/3519
lorisleiva
force-pushed
the
loris/accept-bigints-in-error-factories
branch
from
2d5d282 to
2ee94ba
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the failing tests introduced in the previous PR pass.
See #3518.