This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
#10095 renamed is_last_data to is_last_in_fec_set. However, the code shows that this is actually meant to indicate where the serialized data is complete: https://github.com/solana-labs/solana/blob/420174d3d/ledger/src/shred.rs#L599-L600 https://github.com/solana-labs/solana/blob/420174d3d/ledger/src/shred.rs#L229-L231 There are multiple FEC sets for each `&[Entry]` serialized and this flag does not represent shreds last in FEC sets (only the very last one by overlap). So the name is wrong and confusing (cherry picked from commit 3b85cbc) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
- Loading branch information