Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Enhance getConfirmation RPC API to include the transaction error code #1285

Closed
mvines opened this issue Sep 20, 2018 · 1 comment
Closed

Enhance getConfirmation RPC API to include the transaction error code #1285

mvines opened this issue Sep 20, 2018 · 1 comment
Assignees
@mvines
Milestone
v0.9 Swamis

Comments

@mvines
Copy link
Contributor

mvines commented Sep 20, 2018

Right now Transactions can fail internally and have no way to report this failure, as the transaction is considered executed.

eg:

solana/src/system_contract.rs

Line 59 in a6c1568

return;

We can have transactions report an error code that gets stored in the bank alongside the transaction signature, fetch-able by the getConfirmation API. Transactions can then be either not confirmed, or confirmed with a given error code.
@mvines mvines added this to the v0.9 Swamis milestone Sep 20, 2018
@mvines
Copy link
Contributor Author

mvines commented Sep 21, 2018

Depends-on: #1298

@mvines mvines self-assigned this Sep 26, 2018
@mvines mvines mentioned this issue Sep 27, 2018
Merged
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@dependabot
build(deps): bump @solana/web3.js in /token-lending/js (solana-labs#1285
776655b 
)

Bumps [@solana/web3.js](https://github.com/solana-labs/solana-web3.js) from 0.92.1 to 0.92.2.
- [Release notes](https://github.com/solana-labs/solana-web3.js/releases)
- [Commits](solana-labs/solana-web3.js@v0.92.1...v0.92.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@adamlaska adamlaska mentioned this issue Jul 31, 2022
Closed
@Kashuhackerone Kashuhackerone mentioned this issue Jul 31, 2022
Open
@Muqingluan Muqingluan mentioned this issue Aug 1, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mvines mvines

Labels
None yet
Projects
None yet
Milestone
v0.9 Swamis
Development

No branches or pull requests
1 participant
@mvines