Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

scripts/wallet-sanity.sh needs to reset its id between runs #1387

Closed
mvines opened this issue Sep 28, 2018 · 6 comments
Closed

scripts/wallet-sanity.sh needs to reset its id between runs #1387

mvines opened this issue Sep 28, 2018 · 6 comments
Assignees
@CriesofCarrots
Milestone
v0.9 Swamis

Comments

@mvines
Copy link
Contributor

mvines commented Sep 28, 2018

Testnet-sanity is failing on master/0.9 because we don’t clear the wallet id anymore, which causes this assertion to fail:
https://github.com/solana-labs/solana/blob/v0.9/scripts/wallet-sanity.sh#L37

Example failure:
https://buildkite.com/solana-labs/testnet-sanity/builds/2810#a41ee78f-a809-4eb2-ae69-7d9de8818776
@mvines mvines added this to the v0.9 Swamis milestone Sep 28, 2018
@CriesofCarrots
Copy link
Contributor

Ah yes. Options here include: deleting .config/solana/id.json before the first solana-wallet command; running solana-keygen at the top of wallet-sanity; or checking wallet balance first thing and spending any tokens >0
@mvines do you have a preference?

@mvines
Copy link
Contributor Author

mvines commented Sep 28, 2018

Running keygen to just explicitly create a new wallet seems nice. Can you take this issue?

@CriesofCarrots
Copy link
Contributor

Yep!

@CriesofCarrots CriesofCarrots self-assigned this Sep 28, 2018
@CriesofCarrots CriesofCarrots mentioned this issue Sep 28, 2018
Merged
@mvines
Copy link
Contributor Author

mvines commented Sep 28, 2018

Hmm, this still reproduces with #1388

@mvines mvines reopened this Sep 28, 2018
@mvines
Copy link
Contributor Author

mvines commented Sep 28, 2018

Ah, the network just needs to be redeployed first I think

@mvines
Copy link
Contributor Author

mvines commented Sep 28, 2018

Yep redeploy got things unstuck

@mvines mvines closed this as completed Sep 28, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@dependabot
build(deps-dev): bump eslint from 7.20.0 to 7.21.0 in /token-swap/js (s…
8c1c116 
…olana-labs#1387)

Bumps [eslint](https://github.com/eslint/eslint) from 7.20.0 to 7.21.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.20.0...v7.21.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jan 17, 2022
Open
Closed
buffalojoec pushed a commit to buffalojoec/solana that referenced this issue May 17, 2024
@joncinque
rpc-client: Print transaction logs in preflight error (solana-labs#1387)
4f6dd3d 
* rpc-client: Print transaction logs in preflight error

* Address feedback

* Update expected error message in program deploy test

* Use a semicolon before the data
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CriesofCarrots CriesofCarrots

Labels
None yet
Projects
None yet
Milestone
v0.9 Swamis
Development

No branches or pull requests
2 participants
@mvines @CriesofCarrots