Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

[Incremental Snapshots] Refactor the common code in snapshot_utils::bank_to_xxx_snapshot_archive() and core/tests/snapshots.rs::make_xxx_snapshot_archive() #18972

Closed
Tracked by #17088
brooksprumo opened this issue Jul 29, 2021 · 1 comment · Fixed by #18565
Closed
Tracked by #17088

[Incremental Snapshots] Refactor the common code in snapshot_utils::bank_to_xxx_snapshot_archive() and core/tests/snapshots.rs::make_xxx_snapshot_archive() #18972

brooksprumo opened this issue Jul 29, 2021 · 1 comment · Fixed by #18565
Assignees
@brooksprumo
Labels
good first issue Good for newcomers locked issue

Comments

@brooksprumo
Copy link
Contributor

Refactor the common code in snapshot_utils::bank_to_xxx_snapshot_archive() and core/tests/snapshots.rs::make_xxx_snapshot_archive() into new functions in snapshot_utils.

These functions will basically be:

fn package_process_and_archive() {
    pacakge_xxx_snapshot();
    process_accounts_package_pre();
    archive_snapshot_package();
}

Original PR comment below

hmm is there a reason this can't be encapsulated within a single call to the bank_to_incremental_snapshot_archive() function? Would prefer to call/test the top-level function instead of replicating that internal logic.

Originally posted by @carllin in #18565 (comment)
This was referenced Jul 29, 2021
Merged
Closed
@brooksprumo brooksprumo self-assigned this Jul 29, 2021
@brooksprumo brooksprumo added the good first issue Good for newcomers label Jul 29, 2021
@brooksprumo brooksprumo linked a pull request Jul 29, 2021 that will close this issue
Add test_bank_forks_incremental_snapshot() #18565
Merged
brooksprumo added a commit to brooksprumo/solana that referenced this issue Jul 29, 2021
@brooksprumo
Add snapshot_utils::package_process_and_archive_xxx_snapshot() (Fixes s…
ba0f6dc 
…olana-labs#18972)
brooksprumo added a commit that referenced this issue Jul 29, 2021
@brooksprumo
Add test_bank_forks_incremental_snapshot() (#18565)
b05fb87 
This commit builds on PR #18504 by adding a test to core/tests/snapshot.rs for Incremental Snapshots. The test adds banks to bank forks in a loop and takes both full snapshots and incremental snapshots at intervals, and validates they are rebuild-able.

For background info about Incremental Snapshots, see #17088.

Fixes #18829 and #18972
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brooksprumo brooksprumo

Labels
good first issue Good for newcomers locked issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test_bank_forks_incremental_snapshot() brooksprumo/solana
1 participant
@brooksprumo