Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFCs 0002-consensus.md and 0004-leader_rotation.md are a confusing #1924

Closed
aeyakovenko opened this issue Nov 27, 2018 · 3 comments
Closed

RFCs 0002-consensus.md and 0004-leader_rotation.md are a confusing #1924

aeyakovenko opened this issue Nov 27, 2018 · 3 comments
Assignees
@aeyakovenko @rob-solana
Milestone
v0.11 Tabletops

Comments

@aeyakovenko
Copy link
Member

aeyakovenko commented Nov 27, 2018 •
edited
Loading

Problem

The two RFCs are confusing, incomplete and overlap in information.

Proposed Solution

  • RFC 0002-branch_generation.md
    This should cover how a leader starts generating a new branch, transmits virtual ticks, how a validator collects the branches and votes.

  • RFC 0004-leader-rotation.md
    This should cover how leaders are picked, how they are rotated, and what state is kept in the bank to do the rotation.

  • RFC 0005-branch-selection.md
    This should cover the state machine for maintaining vote lockouts and how validators make the choice of what branch to vote on.

  • rename 0007-staking.md to 0007-staking-rewards.md

*tag: @rob-solana @garious @carllin
@rob-solana rob-solana self-assigned this Nov 27, 2018
@aeyakovenko
Copy link
Member Author

@rob-solana i am working on a PR for this

@rob-solana
Copy link
Contributor

ok

@garious garious added this to the The Future! milestone Nov 28, 2018
@garious
Copy link
Contributor

garious commented Nov 29, 2018

@aeyakovenko, I'm somewhat blocked by this. Is your PR coming this week?

@aeyakovenko aeyakovenko mentioned this issue Nov 29, 2018
Merged
@garious garious modified the milestones: The Future!, v0.11 Tabletops Dec 9, 2018
@snyk-bot snyk-bot mentioned this issue Jun 9, 2021
Open
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@dependabot
build(deps-dev): bump rollup from 2.51.2 to 2.52.0 in /token/js (sola…
4b699da 
…na-labs#1924)

Bumps [rollup](https://github.com/rollup/rollup) from 2.51.2 to 2.52.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.51.2...v2.52.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@n4st0r n4st0r mentioned this issue Mar 11, 2024
Open
@Exkaleburx Exkaleburx mentioned this issue May 4, 2024
Open
@BuloZB BuloZB mentioned this issue May 19, 2024
Open
willhickey pushed a commit that referenced this issue Jul 10, 2024
@mergify @CriesofCarrots @willhickey
v1.18: Deprecate RpcClient::get_stake_activation (backport of #1895) (#…
4e58224 
…1924)

Deprecate RpcClient::get_stake_activation (#1895)

* Deprecate RpcClient::get_stake_activation

* Fixup redelegation test

(cherry picked from commit 114041c)

Co-authored-by: Tyera <tyera@anza.xyz>
ruuda pushed a commit to ChorusOne/solana that referenced this issue Jul 15, 2024
@mergify @CriesofCarrots
v1.18: Deprecate RpcClient::get_stake_activation (backport of solana-…
d48afb8 
…labs#1895) (solana-labs#1924)

Deprecate RpcClient::get_stake_activation (solana-labs#1895)

* Deprecate RpcClient::get_stake_activation

* Fixup redelegation test

(cherry picked from commit 114041c)

Co-authored-by: Tyera <tyera@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeyakovenko aeyakovenko

@rob-solana rob-solana

Labels
None yet
Projects
None yet
Milestone
v0.11 Tabletops
Development

No branches or pull requests
3 participants
@garious @aeyakovenko @rob-solana